You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes PR notifications for CCPP-Physics get lost in the large amount of notification noise.
Solutions
Here are a list of possible solutions, depending on the preferred avenue for notification. All of these can be added to a Github action that will be performed when a PR is created.
comment action: add comment to PR to mention specific @foo-username
email action: send special email every time a PR is created.
modify email setting to highlight specific message
more difficult but also more fun ways to do this, automatically send a slack message or tweet
Related to (optional)
This got brought up in Wednesday's CCPP physics management meeting on the behalf of @climbfuji. Does this issue accurately reflect this problem and what do you think of the possible solutions, @climbfuji?
The text was updated successfully, but these errors were encountered:
My first reaction is that there's probably a misunderstanding of the word CODEOWNERS. I think that Github chose a very unfortunate name, since being listed as a codeowner is basically a good mechanism for being notified, requested to submit a review, and thereby signal to the repo managers (those with admin/maintainer privilege to merge code) that the code was reviewed and the changes are ok. If that file had a different name, this discussion might not even be needed. Any of the solutions listed above are (a) additional work compared to using a tool that's already out there, and (b) fail to give the repo managers a quick way to see if the folks who should be looking at the code changes did so.
Description
Sometimes PR notifications for CCPP-Physics get lost in the large amount of notification noise.
Solutions
Here are a list of possible solutions, depending on the preferred avenue for notification. All of these can be added to a Github action that will be performed when a PR is created.
@foo-username
@foo-username
Related to (optional)
This got brought up in Wednesday's CCPP physics management meeting on the behalf of @climbfuji. Does this issue accurately reflect this problem and what do you think of the possible solutions, @climbfuji?
The text was updated successfully, but these errors were encountered: