Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[session] Config file should be an option for the base command #442

Open
viklund opened this issue Aug 28, 2024 · 0 comments · May be fixed by #458
Open

[session] Config file should be an option for the base command #442

viklund opened this issue Aug 28, 2024 · 0 comments · May be fixed by #458
Assignees
@pahatz
Labels
demo enhancement New feature or request refactor

Comments

@viklund
Copy link
Member

viklund commented Aug 28, 2024 •
edited by kostas-kou
Loading

As a user of the tool
I want options that apply settings for all subcommands to come before subcommands
So that it's easier to understand what is what

Description

It's weird that the more "global" options are specified for each subcommand instead of globally.

sda-cli -config <config-file> list --dataset <dataset>

A/C

  • it's possible to specify the config file as an option to the base command instead of the subcommands
  • add tests

Demo

2 minutes.
@viklund viklund added demo enhancement New feature or request labels Aug 28, 2024
@pahatz pahatz self-assigned this Oct 2, 2024
@pahatz pahatz linked a pull request Oct 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pahatz pahatz

Labels
demo enhancement New feature or request refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config file provided before command NBISweden/sda-cli
3 participants
@viklund @pahatz @jbygdell