Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbpy.spectroscopy.SpectralSource class subclasses synphot.spectrum.SourceSpectrum #291

Open
2 of 5 tasks
jianyangli opened this issue Jun 24, 2021 · 0 comments
Open
2 of 5 tasks
Labels
feature request request for new functionality spectroscopy

Comments

@jianyangli
Copy link
Contributor

This is a request for

  • a new feature
  • an enhancement to existing sbpy functionality
  • somethings else: [explain here]

The requested changes will be implemented by

  • me
  • the sbpy developers

High-level concept
Currently sbpy.spectroscopy.SpectralSource has the spectrum in a synphot.spectrum.SourceSpectrum instance as a class attribute. By subclassing synphot.spectrum.SourceSpectrum, sbpy SpectralSource would allow for various operations defined for synphot.spectrum.SourceSpectrum, such as addition, subtraction, and multiplications of two spectra, etc. This would simplify some operations such as spectral reddening.

Explain the relevance to sbpy
An enhancement to sbpy class SpectralSourcer.

Proposal details
SpectralSource class subclasses synphot SourceSpectrum, and various adjustments to the implementation of class methods.

Example (pseudo-)code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for new functionality spectroscopy
Projects
None yet
Development

No branches or pull requests

1 participant