From 2ec9ed83a2a1d79428dedd90e4cc552fa0ace994 Mon Sep 17 00:00:00 2001 From: "James V. Geiger" Date: Fri, 4 Sep 2020 11:18:02 -0400 Subject: [PATCH] Fix jules50_qc_soilmobs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The elseif block for "elseif (l_aggregate)" should be moved to the end of the whole if block. Otherwise, QCs for sneqv_obs and fsno_obs do not work ever when l_aggregate = true.  --- .../land/jules.5.0/da_soilm/jules50_qc_soilmobs.F90 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lis/surfacemodels/land/jules.5.0/da_soilm/jules50_qc_soilmobs.F90 b/lis/surfacemodels/land/jules.5.0/da_soilm/jules50_qc_soilmobs.F90 index 9942f8ed4..985973b45 100644 --- a/lis/surfacemodels/land/jules.5.0/da_soilm/jules50_qc_soilmobs.F90 +++ b/lis/surfacemodels/land/jules.5.0/da_soilm/jules50_qc_soilmobs.F90 @@ -405,10 +405,6 @@ subroutine jules50_qc_soilmobs(n,k,OBS_State) smobs(t) = LIS_rc%udef elseif(vegt_obs(t).eq.9) then !Land-ice smobs(t) = LIS_rc%udef - elseif(l_aggregate) then - if (smcmax_obs(t) == 0) then !glacier grid !Yonghwan Kwon - smobs(t) = LIS_rc%udef - endif elseif(sneqv_obs(t).gt.0.001) then smobs(t) = LIS_rc%udef elseif(fsno_obs(t).gt.0) then @@ -425,6 +421,10 @@ subroutine jules50_qc_soilmobs(n,k,OBS_State) !elseif(smobs(t) - smcwlt_obs(t).lt.0.02) then ! changed from 0.02 to ... ! smobs(t) = LIS_rc%udef !Yonghwan Kwon: Temporary commented out + elseif(l_aggregate) then + if (smcmax_obs(t) == 0) then !glacier grid !Yonghwan Kwon + smobs(t) = LIS_rc%udef + endif endif endif enddo