Enable convenient, shorter ingest definitions for single-asset items #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anayeaye
reviewed
Aug 16, 2023
| items_with_assets = group_by_item(file_uris, id_regex, assets) | ||
|
|
||
| if len(file_uris) == 0: | ||
| raise ValueError(f"No files discovered at bucket: {bucket}, prefix: {prefix}") |
ividito
approved these changes
Aug 16, 2023
anayeaye
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Summary of changes
This PR is aimed at simplifying the definition of single-asset item ingests. If no
assetsfield is provided to discovery, it will now assume that the oldercog_defaultstrategy is appropriate for registering item assets.Changes
PR Checklist