Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable default api gateway endpoint for workflows api #247

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

botanical
Copy link
Member

@botanical botanical commented Oct 21, 2024

Issue

https://github.com/NASA-IMPACT/veda-architecture/issues/452

What/Why

This disables the default API Gateway endpoint for the workflow API. Instead, access should be done through the custom domain endpoints.

NOTE:

  • for all the stacks that need this disabled, add TF_VAR in the secret

@botanical botanical added bug Something isn't working work in progress and removed bug Something isn't working labels Oct 21, 2024
Copy link
Contributor

@smohiudd smohiudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, with TF_VAR change

@botanical botanical merged commit 61a797d into dev Oct 24, 2024
3 checks passed
@botanical botanical deleted the jt/issue-452-disable-default-endpoint branch October 24, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants