Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time data connection lost dialog is blocking and asks users to reload which may not be necessary #177

Open
chesterhawkins opened this issue May 15, 2024 · 0 comments · May be fixed by #190

Comments

@chesterhawkins
Copy link
Contributor

chesterhawkins commented May 15, 2024

Describe the sustaining activity

The Real-time data connection lost dialog is blocking and encourages users to reload the view when a reload may not be necessary (e.g. The reported disconnection appears to be the result of a closed connection when navigating away from a view and not a closed connection relating to the current view). Replaced the dialog with a console warn and alert notification so users would be aware that a potential issue exists but can still see their displays and see if data is updating as expected.

Expected behavior

Configurable "Real-time connection lost" notification (blocking vs non-blocking). Default to non-blocking.

Testing Instructions

  1. Test default (no config change) real-time connection lost dialog, confirm it is non-blocking.
  2. Configure the real-time connection lost notification to be blocking, confirm it's blocking.

Additional context

@chesterhawkins chesterhawkins added the defect every defect must have an accompanying criticality, or `crit-` label May 15, 2024
@davetsay davetsay added sustaining and removed defect every defect must have an accompanying criticality, or `crit-` labels Sep 3, 2024
@davetsay davetsay added this to the MC2412 Sprint 5 milestone Sep 3, 2024
@davetsay davetsay linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants