-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java init checks are a little unclear #100
Comments
Yeah that is kinda of a problem. WAIL electron needs a full rewrite. |
I asked a related question on the IIPC #heritrix Slack channel and @anjackson stated
I am wondering if we should try to utilize the native Java if available and otherwise download the latest available for the platform. This would require testing Heritrix's capability on newer Java that nobody seems to have time for until then need Heritrix on their system. :D Rewrites take a lot of cycles but in the interest of future endeavors, how would you do things differently if WAIL were rewritten? I think, for this ticket, we can at least revise the verbiage. |
Yeah I should have taged the other ticket about can not skip java install as well. The biggest part of the rewrite would be use prebuilt sql dists (npm packages) rather than the nedb, less windows etc.
|
Are you submitting a bug report or a feature request?
Feature request
What is the current behavior?
I am using a fairly fresh macOS 10.14 that does not have Java installed. For another tool, I installed Java 11. On WAIL's first-launch, it recognizes that Java 1.7 does not exist on the file system, asks if I want to install it to use Heritrix, then gives me an unclear warning when I state indicate "no".
What is the expected behavior?
Ideally, Heritrix would use the installed version of Java (11 per above) but that is out of the scope of WAIL. Is Heritrix still limited to Java 7?
Expected behavior might be to indicate the severity of a user checking "no" to installing Java 7. The tone in the main window is that one can continue using WAIL without Heritrix where the popup explicitly states that WAIL cannot be used without Heritrix (which I believe to not be true, @N0taN3rd?).
The alert has an odd clarity issue, asking "Are you sure you don't want to install?" requires some pause to parse. Suggested revision for the alert window:
What's your environment?
macOS 10.14, WAIL v1.2.0-beta3, java 11.0.1 2018-10-16 LTS
Other information
The text was updated successfully, but these errors were encountered: