Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Names on Loot Conditions around the wrong way? (1.18) #321

Open
trabpukcip opened this issue Aug 23, 2022 · 1 comment
Open

Registry Names on Loot Conditions around the wrong way? (1.18) #321

trabpukcip opened this issue Aug 23, 2022 · 1 comment

Comments

@trabpukcip
Copy link

While trying my best to understand loot conditions looking at source code, these 2 lines in ModLoot.java looked like the names could be switched around.

I.e. "is_obsidian" and "is_lava" are assigned to the wrong things.

Is this intentional behaviour?

public static final RegistryObject<LootItemConditionType> IS_OBSIDIAN = CONDITIONS.register("is_lava", () -> new LootItemConditionType(new IsObsidianCondition.ObsidianSerializer()));
public static final RegistryObject<LootItemConditionType> IS_LAVA = CONDITIONS.register("is_obsidian", () -> new LootItemConditionType(new IsLavaCondition.LavaSerializer()));

@noobanidus
Copy link
Collaborator

That would be a bug rather than a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants