Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add workflows for publishing to GH Pages #13

Merged
merged 5 commits into from
Jun 6, 2024
Merged

ci: add workflows for publishing to GH Pages #13

merged 5 commits into from
Jun 6, 2024

Conversation

mlegner
Copy link
Collaborator

@mlegner mlegner commented Jun 6, 2024 •
edited
Loading

  • Deploy every commit on main with relevant changes.
  • Generate and publish previews for every PR with relevant changes.

Closes #3

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-06 15:07 UTC

@mlegner mlegner marked this pull request as ready for review June 6, 2024 12:47
@mlegner mlegner requested a review from gdanezis June 6, 2024 12:47
gdanezis
gdanezis approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@gdanezis gdanezis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great recipes.

How should we handle the link checker excluding private repo pages? Obviously we cannot wait for public release to check for broken links? Any ideas on how to handle this?

@mlegner
Copy link
Collaborator Author

mlegner commented Jun 6, 2024

How should we handle the link checker excluding private repo pages? Obviously we cannot wait for public release to check for broken links? Any ideas on how to handle this?

Given the fact that we just have a very low number of such exceptions, I would suggest to just test those manually. Currently, there is just the link to the GitHub repository.

@mlegner mlegner merged commit 7134758 into main Jun 6, 2024
6 checks passed
@mlegner mlegner deleted the ml/pages-deploy-and-preview branch June 6, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdanezis gdanezis gdanezis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up workflow to publish documentation with GitHub pages
2 participants
@mlegner @gdanezis