Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where does bad Korean translation come from? #59

Open
JuliaC29 opened this issue Dec 5, 2018 · 3 comments
Open

Where does bad Korean translation come from? #59

JuliaC29 opened this issue Dec 5, 2018 · 3 comments

Comments

@JuliaC29
Copy link

JuliaC29 commented Dec 5, 2018

In my ko-kr/current.local.weather.dialog file I have:

현재 **{{condition}}**고 기온은 {{temp}}도입니다. 오늘의 최고 기온은 {{temp_max}}도, 최저 기온은 {{temp_min}}도입니다.

When I ask mycroft the weather, I get:

날씨가 어때?
현재 맑음고 기온은 6도입니다. 오늘의 최고 기온은 6도, 최저 기온은 0도입니다.

I don't find the string 맑음 anywhere in my code.

juyeon@ju:/opt/mycroft/skills/mycroft-weather.mycroftai$ grep -nHr 맑음 . | wc -l
0

It is not correct Korean in this context. It should be 맑. Is this coming from OWM ? Is there a way to override what they send ?

@KathyReid
Copy link
Contributor

Hi @JuliaC29, in order for us to diagnose this we will need to see your skills.log.
Are you able to provide this for us please?

https://mycroft.ai/documentation/troubleshooting/#how-to-find-the-mycroft-logs

@forslund
Copy link
Collaborator

forslund commented Dec 6, 2018

Hi @JuliaC29 it is most likely the OWM translations that was added recently. (PR #52) If you feel it's better to not use the korean translation from OWM we can remove L675 and remove 'kr' from L683

@chrisveilleux
Copy link
Member

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants