Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No translation of the temperature scales #189

Open
putnik opened this issue Nov 5, 2021 · 2 comments
Open

No translation of the temperature scales #189

putnik opened this issue Nov 5, 2021 · 2 comments

Comments

@putnik
Copy link
Contributor

putnik commented Nov 5, 2021

Describe the bug
In weather messages, the temperature scale is not translated into the selected language.

To Reproduce
Steps to reproduce the behavior:

  1. Change language to Russian
  2. Ask for current weather few times
  3. Wait for message with scale
  4. See untraslated scale (celsius/fahrenheit):
>> Сейчас небольшой дождь и 11 градусов celsius.
>> Сейчас дождь и 51 градусов fahrenheit.

Expected behavior
Scales should be translated.

Environment:

  • Device type: Raspberry Pi
  • OS: Picroft
  • Mycroft-core version: dev
@putnik putnik added the bug label Nov 5, 2021
@putnik putnik changed the title No translation of the degrees scales No translation of the temperature scales Nov 5, 2021
@krisgesling
Copy link
Contributor

Hey, thanks for flagging this. It certainly isn't the intention. I'm not sure when someone from our team will get to it so I've added a help wanted flag for now.

@forslund
Copy link
Collaborator

forslund commented Jan 4, 2022

This should be resolved by #197, I started out with a simple change to just translate the unit as other things are translated but in the end I ended up suggesting a slight reorganization to make the translations occur where the dialog is built to make it easier to avoid these kinds of issues in the future.

(It was tested with Swedish)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants