Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No city info in response #16

Open
MatthewScholefield opened this issue Nov 10, 2017 · 2 comments
Open

No city info in response #16

MatthewScholefield opened this issue Nov 10, 2017 · 2 comments

Comments

@MatthewScholefield
Copy link
Collaborator

hey mycroft, when will it rain in the sun
light rain is expected on saturday

So, it appears it will, in fact, rain on the sun in just a few days. However, I assume this is because the location API found a match for a location who has sun in its name (such as maybe sun city or something like that). While this is ok, I'd at least expect it to say where it is going to rain on Saturday.

@penrods
Copy link
Collaborator

penrods commented Feb 14, 2018

What does this even mean -- "when will it rain in the sun"? What do you expect it to be doing?

@penrods
Copy link
Collaborator

penrods commented Feb 14, 2018

After talking I understand what you mean. "hey mycroft, when will it rain in Tokyo" just says "Light rain is expected tomorrow". This doesn't include a confirmation of the city. This isn't a big deal if there isn't an issue, but there could be an issue if there is ambiguity on the city returned.

For example, "When will it rain in Homewood" might return the city in Alabama or the city in Illinois. With no city prompt, you might not know that you just got the result for the wrong city.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants