Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyowm to latest version #157

Closed
domcross opened this issue Mar 20, 2021 · 5 comments · Fixed by #158
Closed

Bump pyowm to latest version #157

domcross opened this issue Mar 20, 2021 · 5 comments · Fixed by #158
Assignees

Comments

@domcross
Copy link
Contributor

domcross commented Mar 20, 2021

Weather skill's requirements.txt is currently fixed to pyowm==2.6.1 while pyowm is now at version 3.1. OWM introduced some interesting new features that are supported by pyowm 3.x, e.g. One Call API

In case there are specific reasons to stay with pyowm 2.x a version bump to 2.10-LTS should be considered. According to this timeline the pyowm 2.x long-term support will end 05/30/2021 (given that pyowm 3.0 was released on 05/30/2020)

@krisgesling
Copy link
Contributor

Hey there, Chris is working on a big update to this Skill at the moment - including updating the pyowm API version 👍

@krisgesling krisgesling linked a pull request May 19, 2021 that will close this issue
5 tasks
@emphasize
Copy link
Contributor

seems requirements.txt kept untouched
pyowm==2.6.1

@krisgesling
Copy link
Contributor

Hey @chrisveilleux was this meant to get bumped with the move to the "One Call API"?

@emphasize
Copy link
Contributor

Confusingly i haven't found a bit we're using from pyowm

@chrisveilleux
Copy link
Member

I removed pyowm from the skill, but forgot to remove the dependency. A PR 169 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants