Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong time reported for sunrise/sunset #137

Closed
gaganpreet opened this issue Aug 27, 2020 · 7 comments · Fixed by #158
Closed

Wrong time reported for sunrise/sunset #137

gaganpreet opened this issue Aug 27, 2020 · 7 comments · Fixed by #158

Comments

@gaganpreet
Copy link

Mycroft reported wrong times for both sunset and sunrise (for today, 27-08-2020)

Sunset

What time is sunset in Amsterdam?

the sun will set at seven forty p.m. today

Actual time for sunset: 20:38

Sunset

What time is sunrise in Amsterdam?

the sun rose at five forty four a.m. today

Actual sunrise at: 06:42

@gaganpreet gaganpreet changed the title Wrong time reported for sunset Wrong time reported for sunrise/sunset Aug 27, 2020
@forslund
Copy link
Collaborator

Hmm could it be that it doesn't identify the location correctly? And instead it tells the local sunset / sunrise?

@forslund
Copy link
Collaborator

Also I think the time is presented in your set timezone. So for chicago I get 1:14 pm which matches the local 6:14 chicago time

@gaganpreet
Copy link
Author

Hmm could it be that it doesn't identify the location correctly? And instead it tells the local sunset / sunrise?

I'm in Amsterdam and the response is the same for both questions whether I include the location or not: "what time is sunset?" and "What time is sunset in Amsterdam?"

Also I think the time is presented in your set timezone. So for chicago I get 1:14 pm which matches the local 6:14 chicago time

Mycroft is set to the correct local timezone and also replies with the correct current time when I ask "what's the time":

Screenshot_20200829_184144

@kcharlie2
Copy link

I am having the same issue. Mycroft tells me the correct location and time (PST / UTC-8). However, it tells me my local sunset using UTC-0.

@krisgesling
Copy link
Contributor

We're shifting to a newer version of the OWM API which should fix this up. It's not quite ready for testing but will update this ticket when it is

@krisgesling krisgesling linked a pull request May 19, 2021 that will close this issue
5 tasks
@chrisveilleux
Copy link
Member

Is this still an issue since the weather skill refactor was merged?

@gaganpreet
Copy link
Author

Thanks, the skill reports correct sunrise/sunset information now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants