Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill settings Hidden fields are shown #30

Open
forslund opened this issue Jul 13, 2020 · 2 comments
Open

Skill settings Hidden fields are shown #30

forslund opened this issue Jul 13, 2020 · 2 comments

Comments

@forslund
Copy link
Collaborator

forslund commented Jul 13, 2020

The installer skill (for example) uses hidden fields for the Marketplace communication, these are shown in the ui and are not actually hidden.

Possibly this feature should be removed and let the installer skill use a separate api call to check the Marketplace for skills to install/remove.

@krisgesling
Copy link
Contributor

These fields have been removed from that Skill for the moment. Are there other use cases for hidden fields?

If we enable setting uploads (from device > Selene) it could allow Skills to push a configuration change made on one device to all other devices with that version of the settings. I can't think of a good use case that would benefit from the fields being hidden, but feels like it might be useful...

@forslund
Copy link
Collaborator Author

It was especially created for the fields in the installer skill and I think those were the only ones. If the installer skill starts using some other method than hidden fields for market place installation the feature can be dropped.

The fields were made single direction on tartarus if I recall correctly so no device could push changes to them.

The other usecase I could see from these are skill configuration that are defaulted through the settingsmeta and backed up on the mycroft.home but not shown on the skill page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants