Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle changes to Skill settings definitions #260

Open
krisgesling opened this issue May 12, 2021 · 0 comments
Open

Better handle changes to Skill settings definitions #260

krisgesling opened this issue May 12, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@krisgesling
Copy link
Contributor

If the settingsmeta of a Skill is modified in any way it is considered a new version of those settings and is blank for all users.

Hence anytime a Skill gets a minor update, all users have their settings wiped for that Skill. (Technically they aren't wiped, the settings still exist for the old settingsmeta but for the user it's effectively the same as it being wiped). An example of this is the News Skill. We cannot add new stations to the settings without every user needing to reselect their default station.
See: MycroftAI/skill-npr-news#96

Need to discuss the best way to handle this. Eg can we grab the last known settings and attempt to apply those values to the new settings if all the keys match?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant