-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-editor preview render is broken #678
Comments
This is pseudo intentional. The preview was created before the Marketplace existed, and it is not intended to be a pixel perfect preview. Rather, I intended the preview to be representative of a typical view. We could rework it, but this is a moving target for at least some time. Is it worth making accurate for the moment? Or go for the gist? |
Given it's current level of accuracy, I think it should probably either be fixed or disabled. When I first started using it, I hadn't seen anything else in the marketplace. Based purely on the preview render, I was working with my README to cut it way down in length and clean things up (e.g. cutting out the markdown that didn't seem to be rendering properly). I was trying to come up with a solution that would work for both the marketplace and for github (see #677). At some point I decided I needed to see something in the marketplace, realized everything there was rendering in a much nicer format, and that the cleanup I was in the middle of was not necessary. Then I opened this issue, and now we're here. Consider every other skill developer going through a similar process (through to creating an issue/reporting in chat) and the amount of time wasted is pretty huge (not everyone will have the same process, and some might be smarter than me and actually look ahead, but it's sure to trip a few people up at least). If it can't be previewed accurately, it would likely be better to simply link to an example, e.g. link to the raw hello-world README and the hello-world skill in the marketplace. (If you add a query parameter to the market that allows a predefined search, you could also effectively link to the card view). This would help with your moving target, since the market is the target; linking to something there gives a perfect example of how the sample will render in the market's current format. Disabling the preview tab may seem extreme, but in my opinion, seeing the inaccurate preview doesn't help much more than seeing nothing. Either way, I'm rolling the dice that what I have will look decent. |
I pasted it on #677, but just because I've got it handy, here's what I currently see when I try to generate my README: The biggest notes are that the merkdown doesn't render, and things in the sidebar (e.g. the device list) do not render. In case I've done something wrong, here's a screenshot of the editor: And the full text that it generates:
Also worth noting the warning that I don't have categories... right below my list of categories. |
Courtesy note to say I've got something in this week's newsletter to see if somebody wants to give us a hand in getting the preview more accurate. |
Not sure if this is the right place for meta-editor issues, but figured it was close enough. Feel free to move it if it needs to live somewhere else.
The previews of the card and details page seem to render very inaccurately. As an example, I recreated the hello-world readme, and took screenshots of the preview next to the actual renders in the market palce:
Card:
Detail:
In case it is relevant, I'm using Firefox 63.0 (64 bit) on Ubuntu 18.04.
The text was updated successfully, but these errors were encountered: