-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If installing requirements from requirements.sh
fails, msm
should halt execution, not continue to install requirements.txt
#447
Comments
Msm currently will halt if the script dependencies:
system:
apt-get: install -y pianobar
dnf: install -y pianobar
pacman: -S --needed --noconfirm pianobar
skill: # Skill dependencies
- face-detector
- mycroft-calendar
python:
- requests
- pydora This would deprecate |
@KathyReid I could take a look at this. |
For dependencies:
system:
all: pianobar
zypper: -S --needed --noconfirm pianobarXY
skill: # Skill dependencies
- face-detector
- mycroft-calendar
python:
- requests
- pydora Where the package portion would use the "pianobar" from all: on the majority of systems but would invoke zypper on systems that have it using whatever flags and/or package(s) are listed. |
See if this is of any use: https://github.com/icy/pacapt |
How was this Issue identified?
This Issue was raised after the Skills Team Meeting on 28th June based on this PR where
requirements.sh
failed due to conditional distro-based deps, but execution continued andmsm
attempted to installrequrements.txt
.Requested change
If installation of dependencies listed in
requirements.sh
fails for whatever reason, execution is halted, andmsm
does not go on the attempt to installpip
dependencies listed inrequirements.txt
.Broader landscape
The broader issue here is that requirements.sh is open to abuse - how do we move to better package management? We want to do better package management for Skills - such as using
manifest.json
type packaging, but this is a longer term proposition.The text was updated successfully, but these errors were encountered: