ASM Help #520
Comments
|
Hello, Just as preliminary skim through your source the issue might be with the at symbol in the FIELD_NAME and/or TAG_ROOT. Removing that may fix it. I am not super proficient in the ASM portion of the mods, it was implemented by someone else. I will continue to skim through and see if there is anything else I am missing. |
|
Hey! Thanks for the reply!! I thought it could be directory issues like: However changing these did not correct the issue, and i'm stuck scratching my head. I too myself have no knowledge of ASM and prefer going around it. Thank you! |
|
Any thoughts? |
|
Not currently, everything looks like it should be fine when I was comparing
the two. I will continue looking, I have a couple thoughts on what might be
occurring but I need to try a couple things after my work.
On Tue, May 15, 2018, 4:48 AM Andrew ***@***.***> wrote:
Any thoughts?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#520 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADD015ONi5tvk13zOHcKi_Wwk-3kkNh1ks5typZ7gaJpZM4T8k_1>
.
--
~ Joe Goett
|
|
Having reviewed the Javadoc for OW ASM I believe what is occurring is the
version being used is 4.0 which doesn't like the visitMethodInsn function.
This seems to stem from the version of ReflectASM being used. I believe
bumping ReflectASMs version to at least 1.11.0 should fix it as it will use
5.0.3 of the ASM lib which includes the correct visitMethodInsn. I am
unsure why it is a problem in the first place as I would have assumed it
would use the latest.--
~ Joe Goett
|
|
Hey, Yeah i updated it to the latest version 1.11.5, but it keeps crashing: |
|
Interesting, I will try to clone the repo and poke at it once I am home
from work in a few hours. There doesn't appear to be anything obvious with
why it's not working at this point.--
~ Joe Goett
|
|
Yeah i've been scratching my head at this for a couple days now. |
|
Any luck? |
|
Sorry, I have not gotten a change to yet. I will be able to sometime
tomorrow though.
On Fri, May 18, 2018 at 8:24 PM Andrew ***@***.***> wrote:
? @jgoett154 <https://github.com/jgoett154>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#520 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADD013JsAe5tG8BQ69r6KvfPFbRewjSyks5tz2ZAgaJpZM4T8k_1>
.
--
~ Joe Goett
|
|
Alright, |
|
I have finally gotten a chance to take a look at it (sorry for the wait). I can't get it to crash when placing or breaking a sign so far. I also have been able to build it several times so far with a completely fresh run of setupDevEnvironment. I am honestly unsure as to the issues that is occuring with the logs you have provided. It shouldn't be causing any problems as you said. |
|
That's really weird. |
|
Im currently using VSCode for the editor (its what I have and I know works atm) I was using Intellij Idea when I was actively working on MT2. I was using |
|
Yeah I tried building it and it worked. Seems i might have accidentally fixed it somehow. |
|
It seems it cannot find the dependencies, but the gradle script is set to auto download/compile them? |
|
I had noticed when I was running it initially that the DepLoader wasn't downloading ReflectASM and the sqlite jars like it should have. At the time I added the dependency jars directly to the appropriate directory and it loaded fine. Its probably caused by a change in the URLs for the deps, determining the proper URL's and updating them should allow it to load automatically without any issues. I also noticed your EmpiresSchematic was causing some difficulties. You have three updates marked as "06.28.2017", the system expects that to be unique which is why many of the others is mm.dd.yyyy.a where a is a number starting from 1. |
|
Gradle's autodownload doesn't effect the download of the dependencies for MyTown2 typically. We runtime inject them into the classpath so we can easily update them. I forget where the URLs are located atm, I'll add a reply once I locate them again. |
|
Just created a PR that should fix the dependency downloads. Seems Github broke the formatting a bit, always sucks fixing that haha. Edit: Also created a PR for the DB Schema changes to allow it to run updates properly. |
|
Wow, thank you so much for the help. Yeah the Sql Schematic was a bit of a pain to understand at first, but once i got it to work, i forgot about setting unique dates, didn't think it would care all that much either. Now everything works, and the gradle script builds it just fine, with all dependencies. There was just a formatting error i had to fix in your PR 😋 Thank you again 😄 |
|
Your very welcome! I noticed the formatting error but was doing them
through GitHub which seems to not always keep formatting. I'm glad
everything is working now!--
~ Joe Goett
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi.
I basically forked MyEssentials, MyPermissions and MyTown into a single mod.
I made it more "Factions" oriented, with raiding modifications & aesthetic improvements.
I'm planning on keeping it updated and releasing soon, but i have a tiny problem:
It seems i messed something up in the ASM code i copied, which won't let me build.
Was wondering if you could check out what i'm doing wrong:
Empires-Mod Repo
Build Failure: (Pointing to ASM Code):
MC Crash Report when i break a sign:
Build Error:
The text was updated successfully, but these errors were encountered: