Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra bridges #42

Closed
wants to merge 3 commits into from
Closed

Extra bridges #42

wants to merge 3 commits into from

Conversation

seumasdunlop
Copy link
Contributor

Implement #34

Example config where:
bridge - name of the bridge on the host.
networkInterface - the name that the VM OS will assign the new network interface
ipCidr - the IP to assign the network interface in the VM (CIDR format)

cluster:
  nodes:
    worker:
      instances:
        - id: 1
          name: pipeline-1
          host: ubuntu-1
          ip: 192.168.20.210
          extraBridges:
            - bridge: br1
              networkInterface: ens4
              ipCidr: 192.168.21.210/24
            - bridge: br2
              networkInterface: ens5
              ipCidr: 192.168.22.210/24

@MusicDin MusicDin linked an issue Aug 18, 2022 that may be closed by this pull request
Add support for configuring extra bridges #34
Open
@seumasdunlop
Copy link
Contributor Author

@MusicDin what can we do to move this one forward? I haven't touched kubitect for a while but would like to use it for our next cluster and still have this requirement. If this just needs a tidy-up I'm happy to make any changes or if you can think of an alternative method of creating additional bridges I'd be happy to look at implementing it.

@MusicDin
Copy link
Owner

Hi @seumasdunlop,

This feature has been delayed because some major changes were recently made to Kubitect, which have affected how configuration is parsed and evaluated. You can expect this feature to be delivered with the 3.0.0 release within the next two weeks.

@seumasdunlop
Copy link
Contributor Author

Okay. I've since made some further changes to make it more flexible. It is now called extraNetworks and you can set either a bridge or the name of a libvirt network, optionally set a gateway, etc. Are you okay with waiting until v3 has been released before I update this to match the new framework?

@MusicDin
Copy link
Owner

In such case, it would be best to release the new version first, and then add the extraNetworks feature with the capabilities you've mentioned to avoid any potential breaking changes in the next minor release.

If you wish, I can also prepare a PR draft for additionalBridges, that could serve as a helpful guideline for identifying any necessary changes that may need to be made after the new version is released.

@MusicDin MusicDin closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for configuring extra bridges
2 participants
@seumasdunlop @MusicDin