Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cdUp logic #732

Merged
merged 1 commit into from
Apr 20, 2024
Merged

fix cdUp logic #732

merged 1 commit into from
Apr 20, 2024

Conversation

ysalmon
Copy link
Contributor

@ysalmon ysalmon commented Apr 1, 2024

Closes #731.

I did not change the assert(false) part although I do not really understand why it is here : Qt says that the logical operation of moving up is just not done if the parent directory does not exist, so even in the rare case of /.git, we could just keep running or display a warning.

@Murmele
Copy link
Owner

Murmele commented Apr 9, 2024

According to the documentation: This is the path of the .git folder for normal repositories, or of the repository itself for bare repositories.
https://libgit2.org/libgit2/#HEAD/group/repository/git_repository_path
So I don't understand why it could that the folder is not the .git folder?

@ysalmon
Copy link
Contributor Author

ysalmon commented Apr 9, 2024 via email

@Murmele
Copy link
Owner

Murmele commented Apr 9, 2024

Thanks for the clarification. I will merge it as soon as the ci build is working again

@Murmele Murmele self-requested a review April 9, 2024 18:55
@Murmele Murmele merged commit 05deb97 into Murmele:master Apr 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

#612 happening again in different form despite PR #614
2 participants