From 9001e004e48be95ba510e385d2ad959eea487163 Mon Sep 17 00:00:00 2001 From: wolfseifert <56782910+wolfseifert@users.noreply.github.com> Date: Thu, 8 Feb 2024 15:37:12 +0100 Subject: [PATCH 1/4] Update MainWindow.cpp delete-timeline-causes-crash-on-windows-#680 --- src/ui/MainWindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ui/MainWindow.cpp b/src/ui/MainWindow.cpp index ed04212be..bead329b2 100644 --- a/src/ui/MainWindow.cpp +++ b/src/ui/MainWindow.cpp @@ -201,7 +201,7 @@ void MainWindow::setSideBarVisible(bool visible) { splitter->setSizes({static_cast(pos * value), 1}); }); - connect(timeline, &QTimeLine::finished, [timeline] { delete timeline; }); + connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); }); timeline->start(); } From cfc90cd6836121c7f185864885965acd589f67f7 Mon Sep 17 00:00:00 2001 From: wolfseifert <56782910+wolfseifert@users.noreply.github.com> Date: Thu, 8 Feb 2024 15:38:37 +0100 Subject: [PATCH 2/4] Update RepoView.cpp delete-timeline-causes-crash-on-windows-#680 --- src/ui/RepoView.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ui/RepoView.cpp b/src/ui/RepoView.cpp index 1f4866c69..170d7d50e 100644 --- a/src/ui/RepoView.cpp +++ b/src/ui/RepoView.cpp @@ -890,7 +890,7 @@ void RepoView::setLogVisible(bool visible) { setSizes({1, static_cast(pos * value)}); }); - connect(timeline, &QTimeLine::finished, [timeline] { delete timeline; }); + connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); }); timeline->start(); } From b1f5b826578546c4c4e5fa640cd8f216cd42ed4e Mon Sep 17 00:00:00 2001 From: wolfseifert <56782910+wolfseifert@users.noreply.github.com> Date: Wed, 14 Feb 2024 12:45:49 +0100 Subject: [PATCH 3/4] Update MainWindow.cpp reformatted --- src/ui/MainWindow.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ui/MainWindow.cpp b/src/ui/MainWindow.cpp index bead329b2..46586b5f5 100644 --- a/src/ui/MainWindow.cpp +++ b/src/ui/MainWindow.cpp @@ -201,7 +201,8 @@ void MainWindow::setSideBarVisible(bool visible) { splitter->setSizes({static_cast(pos * value), 1}); }); - connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); }); + connect(timeline, &QTimeLine::finished, + [timeline] { timeline->deleteLater(); }); timeline->start(); } From 3cd3ddba593b249471166c82e4330166da8a51ce Mon Sep 17 00:00:00 2001 From: wolfseifert <56782910+wolfseifert@users.noreply.github.com> Date: Wed, 14 Feb 2024 12:47:15 +0100 Subject: [PATCH 4/4] Update RepoView.cpp reformatted --- src/ui/RepoView.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ui/RepoView.cpp b/src/ui/RepoView.cpp index 170d7d50e..713b82cc5 100644 --- a/src/ui/RepoView.cpp +++ b/src/ui/RepoView.cpp @@ -890,7 +890,8 @@ void RepoView::setLogVisible(bool visible) { setSizes({1, static_cast(pos * value)}); }); - connect(timeline, &QTimeLine::finished, [timeline] { timeline->deleteLater(); }); + connect(timeline, &QTimeLine::finished, + [timeline] { timeline->deleteLater(); }); timeline->start(); }