Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rename branch menu #621

Merged
merged 12 commits into from
Aug 30, 2023
Merged

Feature/rename branch menu #621

merged 12 commits into from
Aug 30, 2023

Commits on Aug 29, 2023

  1. feat: add a 'Rename Branch' to the right-click context menu in the co… 

    …mmit list.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2769847 View commit details
    Browse the repository at this point in the history

  2. feat: improve right-click menu for operations on references. 

    Instead of having a big list of references which can be deleted or renamed in the main popup menu  we add a sub-menu for each kind of operation if there is more than one reference for an operation.  If there is only a single reference for an operation, it is added directly to the menu as per the previous implementation.

There's a pro/con here:
* pro: best use of menu with easiest operation in the most common scenario (a single reference).
* con: menu dynamically changes depending on the data, which means users can't learn muscle-memory. For that it's best to maintain a constant top-level menu and enable/disable menu items as required. This might also make the code a little cleaner.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5f5d5e9 View commit details
    Browse the repository at this point in the history

  3. feat: add rename branch to menu bar

    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    86dd4cb View commit details
    Browse the repository at this point in the history

  4. feat: give the Rename Branch dialog a better size. 

    Ideally I would like the dialog to start with a suitable size based on the current branch name, but not force it to be the minimum. However, I could not find a way to do this.

Secondly, it would be nice if the dialog automatically expanded up to some maximum size as the name gets longer, again, there seems to be no easy way to do this.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6321d39 View commit details
    Browse the repository at this point in the history

  5. feat: make Checkout menu multi-level if there are more branches 

    Similar to `Delete` and `Rename`, create a sub-menu if the list of branches available to checkout is larger.

TODO: Perhaps make the collapsible branches an option?
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    baa10eb View commit details
    Browse the repository at this point in the history

  6. refactor: rename submenu entries for Checkout and code clean up 

    The `Checkout` submenu entries all had "Checkout" as part of their entry; remove it since it's overly verbose.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c9aaa86 View commit details
    Browse the repository at this point in the history

  7. refactor(CommitList): move duplicated code generating menu entries in… 

    …to a function.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7721dd2 View commit details
    Browse the repository at this point in the history

  8. chore: fix copyright information in the RenameBranchDialog file com… 

    …ments

Fix the copyright information in the files authored by myself.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    8745c3c View commit details
    Browse the repository at this point in the history

  9. chore: clang-format recently modified files. 

    TODO: add clang-format as a pre-commit and/or pre-push git hook
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    42baad6 View commit details
    Browse the repository at this point in the history

  10. build: update cl-format.sh to force v13 of clang-format 

    The script was designed to find the latest version of clang-format, however, this project currently specifically requires the use of v13. We now only check for v13 of clang-format.

Secondly, for cmake-format the script also requires a specific version. Instead of installing that unmanaged version globally we now install it inside a python venv.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    6185b84 View commit details
    Browse the repository at this point in the history

  11. chore: source code formatting 

    Revert incorrect formatting changes due to use of clang-format v14 in
6ed70b2.
    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    f71f73c View commit details
    Browse the repository at this point in the history

  12. docs: update changelog with rename-branch work.

    @mwerle
    mwerle committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4ef8b60 View commit details
    Browse the repository at this point in the history