From 1d73792b7b9e9a2cac2edc2dc4a64817894b1514 Mon Sep 17 00:00:00 2001 From: Michael Werle Date: Tue, 29 Aug 2023 14:18:21 +0900 Subject: [PATCH] question: CommitList - correct variable to use? The lambda captures `model`, but in the code, `mModel` is used. Either the capture is superfluous, or the usage is incorrect. --- src/ui/CommitList.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/ui/CommitList.cpp b/src/ui/CommitList.cpp index 848662937..a0d8d64b5 100644 --- a/src/ui/CommitList.cpp +++ b/src/ui/CommitList.cpp @@ -1186,6 +1186,7 @@ CommitList::CommitList(Index *index, QWidget *parent) connect(model, &CommitModel::statusFinished, [this, model](bool visible) { mRestoreSelection = true; // Reset to default // Fake a selection notification if the diff is visible and selected. + // FIXME: Should we reference `model` or `this->mModel` here? if (visible && selectionModel()->isSelected(mModel->index(0, 0))) resetSelection();