Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while registering NPC tests #39

Open
brando56894 opened this issue Dec 18, 2020 · 7 comments
Open

Crash while registering NPC tests #39

brando56894 opened this issue Dec 18, 2020 · 7 comments

Comments

@brando56894
Copy link

I'm attempting to register all my NPCs and after about 3-5 minutes xEdit crashes with an unhandled exception stating that its trying to read an unauthorized memory address.

Modsvaskr shows the following
Unhandled exception: undefined local variable or method 'dir' for #<Modsvaskr::Xedit:0x0d8aec18>

Here's the Modsvaskr.log
Here's the SSEEditException.log

Let me know if you need anything else.

@Hausi7447
Copy link

Hausi7447 commented Dec 18, 2020

Having the exact same issue

My Modsvaskr.log
My SSEEditException.log

@Muriel-Salvan
Copy link
Owner

Thanks a lot for reporting it!

Modsvaskr's error (undefined local variable on dir) is in itself a bug that will be corrected in next version (it's already patched on Github).

However the real issue here is that the xEdit script gathering NPC and CELL data is making xEdit crash. No idea yet what can cause such issues in xEdit, but here are some tracks I need to investigate:

  1. The xEdit script keeps all references in a single Array that it dumps in a CSV file at the end of its execution. Maybe the list becomes too big and gives memory problems. If this hypothesis is true:
  • The workaround would be to try with fewer mods (you can run the registering several times with a different set of mods in xEdit to register all mods in several passes).
  • The fix would be to not have to store the whole list in memory. A more clever approach would be to store 1 list per esp, so that we modsvaskr doesn't have to re-scan the same esps twice. Less memory consumed, and a faster scan.
  1. Some esps might have an issue while being scanned. This would be a bug to be resolved by xEdit team, but if this hypothesis is true, a workaround would be to try to isolate the faulty esp in the xEdit selection dialog. As this is a tedious task to do, I think we should first try to improve the first point, then try again.

It would help to have the load order (ordered list of esps) posted in this ticket to narrow a potential faulty esp.

@Hausi7447
Copy link

Hausi7447 commented Dec 18, 2020

My plugins.txt

I'm running a substantial list of ESPs, although none of them make the game crash or seem to have any errors when looking for them through xEdit

I would tend towards number 1, considering my plugin list, but that could also just be a coincidence

@Hausi7447
Copy link

Just a follow up

Tried the same process with only the vanilla ESM files (have only been cleaned)

and i'm getting the exact same error

My Modsvaskr.log
My SSEEditException.log

@DrPariah
Copy link

Same issue with Modvaskr as above, Unhandled exception: undefined local variable or method `dir' for #Modsvaskr::Xedit:0x000000000577f7e0

@Muriel-Salvan
Copy link
Owner

I reviewed the code used to scan esps from xEdit, and found a potential culprit. I corrected it in #34

I'll update this ticket when the new version including this fix will be loaded so you can test (unfortunately the problem does not occur on my setup).

@brando56894
Copy link
Author

I'll give it a try again, this time with a completely different modlist again haha, because I'm having issues once again after playing for like an hour.

@Muriel-Salvan Muriel-Salvan transferred this issue from Muriel-Salvan/AutoTest Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants