Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split cmds functions into their own stubs #29

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

Muream
Copy link
Owner

@Muream Muream commented Sep 15, 2024

depends on #28
closes #25

@Muream
Copy link
Owner Author

Muream commented Sep 15, 2024

@juggernate If you can, I'd be curious to hear if v0.4.2a works better with PyCharm.

I've tested a bit and it seems to work fine without having to resort to the trick you added to the readme a while ago but I'd like the feedback of some actual PyCharm user before publishing

@Muream Muream changed the base branch from master to refactor September 15, 2024 20:29
Base automatically changed from refactor to master September 15, 2024 20:51
@mdilena
Copy link

mdilena commented Nov 5, 2024

Hey, in case you need some feedback on this: I tried the split cmds pre-release out of curiosity, and it made things a little slower to pick up in Visual Studio Code. Not sure if that' what you're using as well, but if so have you noticed any of that?

@Muream
Copy link
Owner Author

Muream commented Nov 5, 2024

Hey, thanks for testing this!

Yeah, I did notice things being slower on vscode (and pyright in neovim)
but on the other hand I've had crashes of Pylance on vscode that I think are due to the huge size of the stubs without splitting them

I'll have to see if there's a middle ground that can be found like simply stripping the docstrings or something like that (the docstrings are maybe 90% of the file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce size of cmds/__init__.pyi
2 participants