Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecart chest stuff #235

Open
dadodasyra opened this issue Sep 10, 2023 · 3 comments
Open

Minecart chest stuff #235

dadodasyra opened this issue Sep 10, 2023 · 3 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@dadodasyra
Copy link
Contributor

Why aren't we using entity inventories like minecraft chest ? This can be more user friendly to avoid spawning a "fake" chest block we can spawn an invisible custom entity with the same components as minecart chests.

This may lead to features like custom inventory sizes too.
https://github.com/tedo0627/InventoryUI is a good starting point

@Muqsit
Copy link
Owner

Muqsit commented Sep 10, 2023

Preference towards block-backed inventories over entity-backed inventories has been discussed in #144 (comment). Custom-sized inventories using tedo0627/InventoryUI has been discussed in #201 (comment).

@Muqsit Muqsit added the question Further information is requested label Sep 10, 2023
@dadodasyra
Copy link
Contributor Author

Preference towards block-backed inventories over entity-backed inventories has been discussed in #144 (comment). Custom-sized inventories using tedo0627/InventoryUI has been discussed in #201 (comment).

interesting, therefore I don't think protocol changes are really a big deal, as invmenu is easy to update for developers I guess it's interesting to still keep an eye on this possibility.
https://github.com/Muqsit/CustomSizedInvMenu should be featured maybe in the ReadMe

@Muqsit
Copy link
Owner

Muqsit commented Sep 12, 2023

interesting, therefore I don't think protocol changes are really a big deal, as invmenu is easy to update for developers I guess it's interesting to still keep an eye on this possibility. https://github.com/Muqsit/CustomSizedInvMenu should be featured maybe in the ReadMe

Looking back at #144, AddActorPacket is already in use by ActorInvMenuGraphic, so there is no added maintenance overhead anymore. Actor-backed inventories can be substituted for block-backed ones, however InvMenu::TYPE_DOUBLE_CHEST would be using a block-backed inventory since no entity inventories feature a 54-slot storage.

@Muqsit Muqsit added the enhancement New feature or request label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants