Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search-derived URLs don't work if shared #932

Closed
morisy opened this issue Dec 4, 2024 · 1 comment · Fixed by #930
Closed

Search-derived URLs don't work if shared #932

morisy opened this issue Dec 4, 2024 · 1 comment · Fixed by #930

Comments

@morisy
Copy link
Member

morisy commented Dec 4, 2024

It looks like search is generating some non-functional URLs currently.

If you go to the Mueller Report, and do a search for Trump:

https://www.documentcloud.org/documents/5955118-The-Mueller-Report/?q=trump&mode=search

Pick page 31 result. That takes you to the expected page, and generates this URL:

https://www.documentcloud.org/documents/5955118-The-Mueller-Report/?mode=document&q=trump#document/p31

But if you paste that URL directly into a blank tab, it takes you to the first page of the document, not the 31st page.
@eyeseast
Copy link
Collaborator

eyeseast commented Dec 4, 2024

This is fixed on #930

@eyeseast eyeseast mentioned this issue Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds redirects for other old embed routes MuckRock/documentcloud-frontend
2 participants
@eyeseast @morisy