From 69e41564220ea166d3eefdc3955e43365a1782d8 Mon Sep 17 00:00:00 2001
From: Allan Lasser <lasser.allan@gmail.com>
Date: Wed, 17 Apr 2024 09:20:24 -0400
Subject: [PATCH] resolve remaining checks

---
 src/common/Dropdown2.svelte                               | 2 ++
 src/config/config.js                                      | 8 ++++----
 src/lib/components/forms/DocumentUpload.svelte            | 7 -------
 .../(embed)/documents/[id]/annotations/[note_id]/+page.ts | 3 +--
 .../(embed)/documents/[id]/pages/[page]/+page.svelte      | 2 --
 5 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/src/common/Dropdown2.svelte b/src/common/Dropdown2.svelte
index d34e9134a..65fb96489 100644
--- a/src/common/Dropdown2.svelte
+++ b/src/common/Dropdown2.svelte
@@ -99,6 +99,8 @@
 <!-- Element to Trigger Dropdown -->
 <div class="dropdownContainer" class:open={isOpen} {id}>
   <div
+    role="button"
+    tabindex={0}
     bind:this={title}
     class={`title ${titleColor}`}
     class:open={isOpen}
diff --git a/src/config/config.js b/src/config/config.js
index a07d90374..d872d7772 100644
--- a/src/config/config.js
+++ b/src/config/config.js
@@ -51,6 +51,9 @@ export const CSRF_HEADER_NAME = "X-CSRFToken";
 
 export const POLL_INTERVAL = 5000;
 
+/**
+ * @type {Array<[string, number]>}
+ */
 export const IMAGE_WIDTHS_ENTRIES = [
   ["xlarge", 2000],
   ["large", 1000],
@@ -59,10 +62,7 @@ export const IMAGE_WIDTHS_ENTRIES = [
   ["thumbnail", 60],
 ];
 
-export const IMAGE_WIDTHS = IMAGE_WIDTHS_ENTRIES.map(([name, width]) => [
-  width,
-  name,
-]).sort((a, b) => a[0] - b[0]);
+export const IMAGE_WIDTHS = IMAGE_WIDTHS_ENTRIES.sort((a, b) => a[1] - b[1]);
 
 export const IMAGE_WIDTHS_MAP = new Map(IMAGE_WIDTHS_ENTRIES);
 
diff --git a/src/lib/components/forms/DocumentUpload.svelte b/src/lib/components/forms/DocumentUpload.svelte
index 9ecebe790..08297ac32 100644
--- a/src/lib/components/forms/DocumentUpload.svelte
+++ b/src/lib/components/forms/DocumentUpload.svelte
@@ -472,13 +472,6 @@
     background: var(--blue-1);
   }
 
-  .excessiveFileSize {
-    padding: 0.25rem;
-    border-radius: 0.25rem;
-    color: var(--red-dark);
-    font-size: var(--font-s);
-  }
-
   .drop-instructions {
     color: var(--gray-5, #233944);
     text-align: center;
diff --git a/src/routes/(embed)/documents/[id]/annotations/[note_id]/+page.ts b/src/routes/(embed)/documents/[id]/annotations/[note_id]/+page.ts
index 672fff91f..dbe83ca2c 100644
--- a/src/routes/(embed)/documents/[id]/annotations/[note_id]/+page.ts
+++ b/src/routes/(embed)/documents/[id]/annotations/[note_id]/+page.ts
@@ -2,11 +2,10 @@
 import * as documents from "@/lib/api/documents";
 import * as notesApi from "$lib/api/notes";
 
-/** @type {import('./$types').PageLoad} */
 export async function load({ params, url, fetch }) {
   const [document, note] = await Promise.all([
     documents.get(+params.id, fetch),
-    notesApi.get(+params.id, params.note_id, fetch),
+    notesApi.get(+params.id, parseInt(params.note_id), fetch),
   ]);
 
   return {
diff --git a/src/routes/(embed)/documents/[id]/pages/[page]/+page.svelte b/src/routes/(embed)/documents/[id]/pages/[page]/+page.svelte
index f5a030ebd..2216e9259 100644
--- a/src/routes/(embed)/documents/[id]/pages/[page]/+page.svelte
+++ b/src/routes/(embed)/documents/[id]/pages/[page]/+page.svelte
@@ -115,13 +115,11 @@
     {#each shimPlacements as s}
       <div
         class="dc-embed-shim"
-        on:click={() => (active = null)}
         style="left:{s[0] * 100}%;top:{s[1] * 100}%;right:{(1 - s[2]) *
           100}%;bottom:{(1 - s[3]) * 100}%"
         tabindex="-1"
         role="dialog"
         aria-modal="true"
-        on:keydown={onKeyup}
       />
     {/each}