Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make shell builder more ergonomic #466

Open
MrPicklePinosaur opened this issue May 30, 2024 · 0 comments
Open

[Feature]: Make shell builder more ergonomic #466

MrPicklePinosaur opened this issue May 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@MrPicklePinosaur
Copy link
Owner

What would you like to see added?

Currently a common pattern for shell builder is

  1. initialize some state like Hooks
  2. insert our data into the state we just defined
  3. insert state into shell builder

As an example:

let mut hooks = Hooks::new();
hooks.insert(my_handler);
let myshell = ShellBuilder::default().with_hooks(hooks);

It would be more ergonomic to eliminate step 2) and provide a method on the shell builder directly to insert a hook, like:

let mut hooks = Hooks::new();
let myshell = ShellBuilder::default().insert_hook(my_handler);

and mirror similar functionality for other state/config.

@MrPicklePinosaur MrPicklePinosaur added the enhancement New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant