Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: History trait should provide method that returns iterator of history rather than a vector #463

Open
MrPicklePinosaur opened this issue May 29, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@MrPicklePinosaur
Copy link
Owner

What would you like to see added?

Currently the history trait specifies:

fn items(&self, sh: &Shell, states: &States) -> Vec<String>;

It would provide much more flexibility to have this be a (generic) iterator over strings to give the implementor of the trait more freedom on the implementation.

@MrPicklePinosaur MrPicklePinosaur added the enhancement New feature or request label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant