Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Styled Components improvements #19

Open
ashfurrow opened this issue Dec 18, 2017 · 3 comments
Open

Adopt Styled Components improvements #19

ashfurrow opened this issue Dec 18, 2017 · 3 comments
Labels
question

Comments

@ashfurrow
Copy link
Member

styled-components is a really popular JS org that uses the Moya contributor guidelines as a base for their own. They recently updated their guidelines and we investigate to see about borrowing ideas back into our own contribute guidelines.
@BasThomas BasThomas mentioned this issue Dec 18, 2017
Merged
@BasThomas
Copy link
Contributor

Awesome, thanks for bringing this up @ashfurrow!

Although I will take some time to let everything I just read sink in, I opened a PR with some fixes (and thoughts) over at Styled Components.

@mxstbr
Copy link

mxstbr commented Dec 18, 2017

Note: Did some more updates today too, make sure you refernence the newest version of the CONTRIBUTING.md/CORE_TEAM.md. styled-components/styled-components#1366

@BasThomas
Copy link
Contributor

Yeah I saw that, was a bit confusing reading through the commit mentioned by Ash and my local copy of master. 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ashfurrow @BasThomas @mxstbr