Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream changes to unixStartScript.txt #643

Open
keturn opened this issue Jul 15, 2021 · 0 comments
Open

upstream changes to unixStartScript.txt #643

keturn opened this issue Jul 15, 2021 · 0 comments
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Maintenance Maintenance or chores not adding new features or fixing bugs.
Milestone

Comments

@keturn
Copy link
Member

keturn commented Jul 15, 2021

Someone with a lot of respect for POSIX sh overhauled the unixStartScript.txt template for gradle 7.2: https://github.com/gradle/gradle/pull/17666/files#diff-a549a2629a3d96f76e3f043a1526e48fb086e90e9d9d03ae0f7abf6d3e803333

I guess now that we're not trying to apply a diff to upstream's copy, we can address this independently of any gradle upgrade, as the names and values of the template variables did not change in that PR.

But at some point we will want to rebase our script on that one so that other future changes to upstream will make sense.

@keturn keturn added Status: Actionable An issue or task that can immediately be worked on Type: Maintenance Maintenance or chores not adding new features or fixing bugs. labels Jul 15, 2021
@skaldarnar skaldarnar added this to the v4.8.0 milestone Nov 9, 2022
soloturn added a commit that referenced this issue Jul 14, 2024
soloturn added a commit that referenced this issue Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Maintenance Maintenance or chores not adding new features or fixing bugs.
Projects
Status: Backlog
Development

No branches or pull requests

2 participants