Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide natives directory to java when launching process #579

Open
keturn opened this issue May 24, 2020 · 1 comment
Open

provide natives directory to java when launching process #579

keturn opened this issue May 24, 2020 · 1 comment
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Enhancement New features or noticable improvements.

Comments

@keturn
Copy link
Member

keturn commented May 24, 2020

The launcher knows where the game is installed and what operating system it's running on.

It can add a -Djava.library.path= argument to java, set to the natives directory for this platform.

See https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/System.html#getProperties()

This will let the main Terasology process avoid trying to change paths at runtime, which is known to interact poorly with some security policies — especially in more recent versions of Java.

See MovingBlocks/Terasology#3937

@keturn keturn added Type: Enhancement New features or noticable improvements. Status: Actionable An issue or task that can immediately be worked on labels May 24, 2020
@keturn
Copy link
Member Author

keturn commented May 24, 2020

(pssst, merge #571 before messing any further with java parameters.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Actionable An issue or task that can immediately be worked on Type: Enhancement New features or noticable improvements.
Projects
None yet
Development

No branches or pull requests

1 participant