Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support feature or sample wise missing values #1

Open
rmflight opened this issue May 21, 2021 · 2 comments
Open

support feature or sample wise missing values #1

rmflight opened this issue May 21, 2021 · 2 comments
Assignees

Comments

@rmflight
Copy link
Member

Currently only a single missing value is supported data-set wide, by providing a single zero_value.

It should be possible to provide feature or sample wise zero values by the user providing a vector that is the same length as either the columns or rows, this would determine whether it is feature or sample wise.

@rmflight
Copy link
Member Author

The way to implement this is at the R code level, where the imputed values are replaced with NA in the data matrix, and then the C++ code handles the missingness.

@rmflight
Copy link
Member Author

After discussion with @hunter-moseley, a design would be to create new parameters:

global_na = c(NA, Inf, 0)
feature_na = NULL
sample_na = NULL

So then if the user changes the global_na they can do that.

@rmflight rmflight self-assigned this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant