Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add formal ways to detect zksync solc throughout the compilation flow #30

Merged
merged 6 commits into from
Oct 14, 2024

Conversation

elfedy
Copy link

@elfedy elfedy commented Oct 11, 2024

  • Add SolcVersionInfo struct that contains both solc and zksync solc version metadata among a get_solc_version_info method to retrieve it from a path to a solc executable
  • Use those in the compilation flow to print the information to the user and also save the value as a field on the compiler output.
  • ZkSolc struct now has SolcVersionInfo in it, this is retrieved when constructing it. It is now more of a zksolc+solc wrapper rather than just the zolc command wrapper.
  • zksolc paths fetch/installation methods now return paths and not the ZkSolc struct,.

Copy link

@Jrigada Jrigada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elfedy elfedy merged commit e3f4437 into zksync-v0.11.1 Oct 14, 2024
4 checks passed
@elfedy elfedy deleted the elfedy-zksync-solc branch October 14, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants