(fix) Replace div_rem with div_mod_floor (lambdaclass#1881)

* replace div_rem with div_mod_floor * format * changelog * remove unwanted programs * clippy * fix changelog
Moonsong-Labs · Dec 3, 2024 · d2c056e · d2c056e
1 parent 577f744
commit d2c056e
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 46 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,8 +2,12 @@
 
 #### Upcoming Changes
 
+* fix: replace `div_rem` with `div_mod_floor` in `verify_zero` hints [#1881](https://github.com/lambdaclass/cairo-vm/pull/1881)
+
 * feat: Implement `SECP related` hints [#1829](https://github.com/lambdaclass/cairo-vm/pull/1829)
 
+* chore: bump pip `cairo-lang` 0.13.3 [#1884](https://github.com/lambdaclass/cairo-vm/pull/1884)
+
 * fix: [#1862](https://github.com/lambdaclass/cairo-vm/pull/1862):
   * Use MaybeRelocatable for relocation table
 

diff --git a/Cargo.lock b/Cargo.lock
diff --git a/vm/src/hint_processor/builtin_hint_processor/secp/field_utils.rs b/vm/src/hint_processor/builtin_hint_processor/secp/field_utils.rs
@@ -36,7 +36,7 @@ pub fn verify_zero(
 ) -> Result<(), HintError> {
     exec_scopes.insert_value("SECP_P", secp_p.clone());
     let val = Uint384::from_var_name("val", vm, ids_data, ap_tracking)?.pack86();
-    let (q, r) = val.div_rem(secp_p);
+    let (q, r) = val.div_mod_floor(secp_p);
     if !r.is_zero() {
         return Err(HintError::SecpVerifyZero(Box::new(val)));
     }
@@ -62,7 +62,7 @@ pub fn verify_zero_with_external_const(
 ) -> Result<(), HintError> {
     let secp_p = exec_scopes.get_ref("SECP_P")?;
     let val = Uint384::from_var_name("val", vm, ids_data, ap_tracking)?.pack86();
-    let (q, r) = val.div_rem(secp_p);
+    let (q, r) = val.div_mod_floor(secp_p);
     if !r.is_zero() {
         return Err(HintError::SecpVerifyZero(Box::new(val)));
     }