From 18c62734be9f61c64b6e16d5bbd3dfe87cb3de8c Mon Sep 17 00:00:00 2001 From: Arne Date: Sun, 24 Sep 2023 17:20:59 +0200 Subject: [PATCH 1/2] Increase update time of static effect to avoid lag --- wled00/FX.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wled00/FX.cpp b/wled00/FX.cpp index 74a705b492..2117c3ab5d 100644 --- a/wled00/FX.cpp +++ b/wled00/FX.cpp @@ -80,7 +80,7 @@ static int8_t tristate_square8(uint8_t x, uint8_t pulsewidth, uint8_t attdec) { */ uint16_t mode_static(void) { SEGMENT.fill(SEGCOLOR(0)); - return 350; + return FRAMETIME; } static const char _data_FX_MODE_STATIC[] PROGMEM = "Solid"; From 0ec54c49112a8a3190eb59e7825ea91b4f4eb34c Mon Sep 17 00:00:00 2001 From: Frank Date: Sat, 7 Oct 2023 16:23:15 +0200 Subject: [PATCH 2/2] WLEDMM specific improvement WLEDMM has FRAMETIME_FIXED_SLOW which seems perfect for this usecase. --- wled00/FX.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wled00/FX.cpp b/wled00/FX.cpp index 2117c3ab5d..66d14b27c0 100644 --- a/wled00/FX.cpp +++ b/wled00/FX.cpp @@ -80,7 +80,7 @@ static int8_t tristate_square8(uint8_t x, uint8_t pulsewidth, uint8_t attdec) { */ uint16_t mode_static(void) { SEGMENT.fill(SEGCOLOR(0)); - return FRAMETIME; + return FRAMETIME_FIXED_SLOW; // WLEDMM to ensure smooth color changes from DMX (PR #73) } static const char _data_FX_MODE_STATIC[] PROGMEM = "Solid";