Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 2D migrated articles #42

Merged
merged 5 commits into from
Aug 10, 2024
Merged

Added 2D migrated articles #42

merged 5 commits into from
Aug 10, 2024

Conversation

SimonDarksideJ
Copy link
Collaborator

Migrated some of the 2D articles, including the primary 2D "whatis" 2D article

@SimonDarksideJ SimonDarksideJ self-assigned this Aug 7, 2024
@CartBlanche
Copy link
Collaborator

@SimonDarksideJ could we possibly have animations showing the desired result too?

@SimonDarksideJ
Copy link
Collaborator Author

As requested @CartBlanche , output images for each sample were added, including animated ones for those that move.

@CartBlanche
Copy link
Collaborator

@SimonDarksideJ we don't need animations for the Matrix docs, right?

@SimonDarksideJ
Copy link
Collaborator Author

The two docs without images are just variants of their base articles, so it feels a little overkill to add to those as well.

Copy link
Collaborator

@CartBlanche CartBlanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CartBlanche
Copy link
Collaborator

@SimonDarksideJ says it's out of sync with the base branch, so might be worth rebasing.

@SimonDarksideJ
Copy link
Collaborator Author

Oh no it isn't 😂
ArisTurtle just fixed the toc's and that needed pulling in, that's all.
Ready for merge again@CartBlanche

@SimonDarksideJ SimonDarksideJ merged commit 402953e into main Aug 10, 2024
2 checks passed
@SimonDarksideJ SimonDarksideJ deleted the feature/graphics2d branch August 10, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants