From 808a95a245da0b2ae1338523e88c6092b1351c2c Mon Sep 17 00:00:00 2001 From: Chris Gillum Date: Fri, 7 Jul 2023 08:44:40 +0900 Subject: [PATCH] [Workflow] Fix issue with ignored external event payload (#1119) * [Workflow] Fix issue with ignored external event payload Signed-off-by: Chris Gillum * Pushing missing commits Signed-off-by: Chris Gillum * Remove unnecessary steps from itests.yml Signed-off-by: Chris Gillum --------- Signed-off-by: Chris Gillum Signed-off-by: Bradley Cotier --- .github/workflows/itests.yml | 10 ---------- src/Dapr.Workflow/Dapr.Workflow.csproj | 6 +++--- src/Dapr.Workflow/DaprWorkflowClient.cs | 12 ++++++------ 3 files changed, 9 insertions(+), 19 deletions(-) diff --git a/.github/workflows/itests.yml b/.github/workflows/itests.yml index 0044fec93..3f42b6bd2 100644 --- a/.github/workflows/itests.yml +++ b/.github/workflows/itests.yml @@ -105,16 +105,6 @@ jobs: - uses: actions/checkout@v1 - name: Parse release version run: python ./.github/scripts/get_release_version.py - - name: Install Local kafka using docker-compose - run: | - docker-compose -f test/Dapr.E2E.Test/deploy/local-test-kafka.yml up -d - docker ps - - name: Install Local Hashicorp Vault using docker-compose - run: | - docker-compose -f test/Dapr.E2E.Test/deploy/local-test-vault.yml up -d - docker ps - - name: Setup Vault's test token - run: echo myroot > /tmp/.hashicorp_vault_token - name: Setup ${{ matrix.display-name }} uses: actions/setup-dotnet@v1 with: diff --git a/src/Dapr.Workflow/Dapr.Workflow.csproj b/src/Dapr.Workflow/Dapr.Workflow.csproj index a951350e8..f6c28b02f 100644 --- a/src/Dapr.Workflow/Dapr.Workflow.csproj +++ b/src/Dapr.Workflow/Dapr.Workflow.csproj @@ -7,14 +7,14 @@ Dapr.Workflow Dapr Workflow Authoring SDK Dapr Workflow SDK for building workflows as code with Dapr - 0.2.0 + 0.3.0 alpha 10.0 - - + + diff --git a/src/Dapr.Workflow/DaprWorkflowClient.cs b/src/Dapr.Workflow/DaprWorkflowClient.cs index 249de09b7..4c4902dbb 100644 --- a/src/Dapr.Workflow/DaprWorkflowClient.cs +++ b/src/Dapr.Workflow/DaprWorkflowClient.cs @@ -70,9 +70,9 @@ public Task ScheduleNewWorkflowAsync( /// The unique ID of the workflow instance to fetch. /// /// Specify true to fetch the workflow instance's inputs, outputs, and custom status, or false to - /// omit them. Defaults to false. + /// omit them. Defaults to true. /// - public async Task GetWorkflowStateAsync(string instanceId, bool getInputsAndOutputs = false) + public async Task GetWorkflowStateAsync(string instanceId, bool getInputsAndOutputs = true) { OrchestrationMetadata? metadata = await this.innerClient.GetInstancesAsync( instanceId, @@ -94,7 +94,7 @@ public async Task GetWorkflowStateAsync(string instanceId, bool g /// The unique ID of the workflow instance to wait for. /// /// Specify true to fetch the workflow instance's inputs, outputs, and custom status, or false to - /// omit them. The default value is false to minimize the network bandwidth, serialization, and memory costs + /// omit them. Setting this value to false can help minimize the network bandwidth, serialization, and memory costs /// associated with fetching the instance metadata. /// /// A that can be used to cancel the wait operation. @@ -104,7 +104,7 @@ public async Task GetWorkflowStateAsync(string instanceId, bool g /// public async Task WaitForWorkflowStartAsync( string instanceId, - bool getInputsAndOutputs = false, + bool getInputsAndOutputs = true, CancellationToken cancellation = default) { OrchestrationMetadata metadata = await this.innerClient.WaitForInstanceStartAsync( @@ -135,7 +135,7 @@ public async Task WaitForWorkflowStartAsync( /// public async Task WaitForWorkflowCompletionAsync( string instanceId, - bool getInputsAndOutputs = false, + bool getInputsAndOutputs = true, CancellationToken cancellation = default) { OrchestrationMetadata metadata = await this.innerClient.WaitForInstanceCompletionAsync( @@ -218,7 +218,7 @@ public Task RaiseEventAsync( object? eventPayload = null, CancellationToken cancellation = default) { - return this.innerClient.RaiseEventAsync(instanceId, eventName, cancellation); + return this.innerClient.RaiseEventAsync(instanceId, eventName, eventPayload, cancellation); } ///