-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use custom errors to save gas? #39
Comments
do wallets know to warn you if a tx will hit a revert? the same way they do for requires: "this transaction will result in an exception" |
The wallet warning seems to work and etherscan decodes the custom error ABI Test with
Require: https://rinkeby.etherscan.io/tx/0xdbb38c3d988c8673a44981f0e28e7b1a24ba5a92c93569fee61f411f14ff3813 Test with revert [Custom Error]
Revert: https://rinkeby.etherscan.io/tx/0x9b4f3bee59a513015463d3b3908cd2469c0934e2396baf920adfa37f19a80862 |
lgtm |
add loot and share singleton to factory constructor
https://blog.soliditylang.org/2021/04/21/custom-errors/
Basically just replace require statement with revert statements
The text was updated successfully, but these errors were encountered: