Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry to setuptools; min py38 #361

Merged
merged 23 commits into from
Nov 26, 2024
Merged

poetry to setuptools; min py38 #361

merged 23 commits into from
Nov 26, 2024

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Nov 26, 2024

Description

  • After all-but-py37 builds spontaneously broke in the last few days, it's easier to move the build backend back in line with other QCA projects (QCFractal and QCManyBody) rather than find the issue with poetry's solve-all-at-once and highly-version-specified format.
  • This should hit most poetry uses and examples. I've already confirmed that new builds on master didn't break, so fine targeting this to next2024.
  • Dialed back the pydantic versions for docs build. There's some errors with latest pydantic, so that pin needs investigating and releasing.
  • Also bump the min python to 3.8+. Even that is end-of-life but QCEngine test lanes still use it.
  • There will likely be refinements and corrections to this switchover, but this is a largely working start.

Changelog description

Status

  • Code base linted
  • Ready to go

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.17%. Comparing base (a1f7dcc) to head (72c4fce).
Report is 5 commits behind head on next2024.

Additional details and impacted files

pyproject.toml Outdated Show resolved Hide resolved
@loriab loriab marked this pull request as ready for review November 26, 2024 06:48
@loriab loriab changed the title poetry to setuptools poetry to setuptools; min py38 Nov 26, 2024
@loriab
Copy link
Collaborator Author

loriab commented Nov 26, 2024

Requesting review @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131

.github/workflows/CI.yaml Outdated Show resolved Hide resolved
.github/workflows/CI.yaml Outdated Show resolved Hide resolved
@loriab loriab merged commit c38fa3c into next2024 Nov 26, 2024
15 checks passed
@loriab loriab deleted the loriab-patch-5 branch November 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants