Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-blocking DeferredMountWithCallback #35

Closed
xaviervia opened this issue Feb 8, 2022 · 1 comment
Closed

Non-blocking DeferredMountWithCallback #35

xaviervia opened this issue Feb 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@xaviervia
Copy link
Contributor

As of #34, when DeferredMountWithCallback is used, all deferred rendering is paused until that callback is invoked.

To avoid blocking all rendering, we might want to place the callback in a second queue for notifying when all rendering is complete, but avoid blocking the start of render of the next component. This should be optional, so that we can also block when waiting for render to be completed before starting the next.

This change does not break API.

We should introduce a new property for signalling when we explicitly want to block further rendering, it could look something like this:

<DeferredMountWithCallback isBlocking>
  <ComponentThatShouldBeWaitedFor />
</DeferredMountWithCallback>
@xaviervia xaviervia added the enhancement New feature or request label Feb 8, 2022
@pirelenito
Copy link
Member

Deferred mount is being deprecated with #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants