-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests (where relevant) don't actually make sure that an exception was thrown. #106
Comments
According to this random article I found, JUnit 5 has an The easiest approach, and one that already seems to be used by some of the existing tests, is to call |
Fixes Mojang#106. Without this, the test could pass if no exception is thrown, in addition to the wanted result of a matching exception being thrown.
JUnit 4 also has an Also Brigadier uses the old Maven artifact coordinates for JUnit: |
Tests like these:
brigadier/src/test/java/com/mojang/brigadier/StringReaderTest.java
Lines 239 to 247 in cf754c4
will actually pass if no exception is thrown.
The text was updated successfully, but these errors were encountered: