Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold: Panel "snap-to" expand should not happen until drag gesture very close to the far edge #11

Open
ldosmorbrian opened this issue Sep 6, 2023 · 1 comment
Assignees

Comments

@ldosmorbrian
Copy link

ldosmorbrian commented Sep 6, 2023

Currently the "snap-to" happens at around the mid-point of the view when the user drags a panel edge to increase the size of the panel.

This is limiting for many use cases where the user still has plenty of space beyond the middle.

However the idea of "snap-to" is reasonable, but should only happen when the drag is very close.
I suggest "2%" as a starting point, and then explore values like "5%" and "1%"

Err on the side of giving the user the most control of the window edge, and limit the Snap-To to a position behavior.

Reference: 11997


This behavior is implemented in ResizeController.ts for each of the right/left/bottom/etc.. panel types.

I experimented with this thinking I could make a quick fix and ticket all at once, but learned that using the mid-point as a snap-to trigger steers relatively clear of some confusing behaviors related to how drag and snapto works when the far-side panels are open.

  • My first quick-fix attempt at this revealed that dragging a side panel toward the far side stretches the entire screen and pushes the right side off screen when the right panel is already open. Meaning, it pushed not just the far right panel, but also the entire top tab bar.

  • As the mid-point is currently used as the trigger, it is not possible to encounter this behavior because the snapto occurs before the far panel can be pushed by the dragging the panel edge.

  • A more complete fix will be possible, but probably needs to address the related side-effects to decide what we want, perhaps even considering whether we snap to the far edge or just to the edge of the open far side panel.

@wowza8448
Copy link

Are there any updates on the status of this bug being fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants