Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions instead of Circle CI #149

Open
grgur opened this issue Sep 9, 2019 · 1 comment
Open

Use GitHub Actions instead of Circle CI #149

grgur opened this issue Sep 9, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@grgur
Copy link
Member

grgur commented Sep 9, 2019

I propose we migrate to GH Actions for this repository testing so we can use the GH Bot out of the box instead of personal tokens for commenting.

@grgur grgur added the enhancement New feature or request label Sep 9, 2019
@mitchellsimoens
Copy link
Collaborator

The downside to gimbal's dockerfile actions is the dockerfile targets the gimbal docker image on docker hub... not the local code in the repo. So like if I were to open a pull request here it will run the local code to check the outcome of any changes. You can execute node code so we could execute gimbal via code but the reason why I didn't do that was because the need for browsers.

Now we could maintain a separate dockerfile to include the browser stuff and copy the gimbal build into the image and use npm link to install it globally (or just execute the bin/index.js directly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants