Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant training config parameter ffn_hidden in the case of SwiGLU #276

Open
flxst opened this issue Dec 4, 2024 · 0 comments
Open

Redundant training config parameter ffn_hidden in the case of SwiGLU #276

flxst opened this issue Dec 4, 2024 · 0 comments

Comments

@flxst
Copy link
Member

flxst commented Dec 4, 2024

The training config parameter ffn_hidden, see e.g. here, currently needs to be specified (as a multiple of 128) although it is only actually used in the case of GeLU. In contrast, if SwiGLU is used, the effective hidden dimension is automatically derived from n_embd instead, see here.

This is misleading and should be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flxst