-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
todo: post v3.0 release #254
Comments
- non-asymptotic estimates are possible - prints a warning if NAs are returned - updating documentation
I changed calc_PIE in my fork. Will write a pull request once I've added the betas. 48224b3 |
Thanks @T-Engel! I'll comment on your fork at your commit |
I just created a new branch from dev for the incorporation of beta_C. (Here: 040a9bb). Now we don't depend on the betaC package. Before we merge into dev, I want to update calc_com_div(). I don't think it makes sense for beta_C to show up as the default for index=S. Can we remove it from there? Maybe it is not a bad idea to leave beta_C out of this big function. If users want to use it, they can just call beta_C directly. Otherwise, calc_comm_div needs a C_target argument, as well. Otherwise, the coverage changes every time depending on the data. What do you think, @dmcglinn ? |
Hey @jmchase @sablowes @T-Engel @FelixMay it would be good to revisit this |
Hi @dmcglinn, thanks for pushing this Dan. I am teaching for the next to weeks, but I am happy to talk or comment afterwards |
Sounds good thanks @FelixMay. I hope teaching goes well. |
code refactoring
get_mob_stats
--> 316776f introducedcalc_comm_div
which accomplishes some of these (get_mob_stats
is obsolete`)tibble
ordata.frame
for easy downstream output to export orggplot
per make it clearer how statistics can be accessed #242mob_in
object (see similar behavior inrarefaction
)make_mob_in
plot_attr
argument rather than a fulldata.frame
see variable names in plot_attributes argument #41rarefaction
dens_ratio
argument is difficult to understand per rarefaction dens_ratio argument #238lchoose
forlgamma
throughout so that floating point abundances can be used per How to compute rarefaction on very small floating point abundances #207 this applies to case in which sampling effort is rounded (need better implementation of rejected PR plot.mob_out uses rounded sampling effort for plot-based rarefaction curve #184)get_delta_stats
plot_rarefaction
new functionality
calc_SPIE
needed to provide a means of computing S_PIE when site has all singletons (i.e., PIE = 1 which results in a division by zero and therefore anNA
value. Essentially this is the difference between using asymptotic S or observed S. Note this replaces some of the functionality of thecalc_PIE
functioncalc_PIE
andcalc_SPIE
in./tests/testhat/
directoryget_mob_stats
andget_delta_stats
over to a formula specification per Add formula specification method for mob stats #239The text was updated successfully, but these errors were encountered: