Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base24 support? #42

Open
KiaraGrouwstra opened this issue Nov 14, 2023 · 2 comments · May be fixed by #58
Open

add base24 support? #42

KiaraGrouwstra opened this issue Nov 14, 2023 · 2 comments · May be fixed by #58

Comments

@KiaraGrouwstra
Copy link

base24 adds bright colors for use in terminals and seems supported by various terminals. it might be cool to see these supported here as well. there are a couple such themes currently, whereas such schemes may be converted back to base16 using a simple fallback table.

@mobsenpai
Copy link

Yeah i would also love to have more colors for theming instead of limited to 16 colors. Can i use/call more colors with this atm? If I use a custom colorscheme with more than 16 colors and names other than base**. @Misterio77

@Misterio77
Copy link
Owner

Misterio77 commented Jan 30, 2024

Hey all!

Yeah, the module already supports arbitrary color names.

The only thing hardcoded to consider 00-0F is the schemeFromYAML function; but that does not apply to you if your theme is defined using nix and not yaml.

I plan on updating that function so that we can work with Tinted Theming's new common format, while keeping compatibility with the older base16/24 format (with the colors at top level). That new format is very similar to what I've been doing here in nix-colors, so I'll probably also rename our options (keeping backwards compatibility, of course) to match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants